Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from dependabot to renovabot #1657

Closed
wants to merge 1 commit into from
Closed

Conversation

dmathieu
Copy link
Member

This is meant to allow upgrading module dependencies (which dependabot doesn't currently look at), while switching to the tool that Platform Engineering recommends using.

@dmathieu dmathieu marked this pull request as ready for review September 25, 2024 12:14
@dmathieu dmathieu requested a review from a team as a code owner September 25, 2024 12:14
Copy link
Member

@kruskall kruskall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: dependabot is only configured to check github-actions because we don't want to force specific library versions on users. The goal was to let users pick the version by using it in their app
dependabot not checking version updates for go dependencies was intendend

@dmathieu
Copy link
Member Author

We do force specific versions on them then. Old ones.

@kruskall
Copy link
Member

We do force specific versions on them then. Old ones.

Nope, because they have a choice to use the version provided by the go agent (the minimum version supported by the agent) or pin to a new version 🙂

The argument when this was made was that the go agent would try to support as many versions as possible and only update if we want to increase the minimum supported version for security (see https://github.com/elastic/apm-agent-go/security/dependabot?q=is%3Aclosed)

@dmathieu dmathieu closed this Sep 25, 2024
@dmathieu dmathieu deleted the renovabot branch September 25, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants