This repository was archived by the owner on Jun 24, 2022. It is now read-only.
heap.dump.path is set as mandatory variable. Setting it to optional i… #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jmlrt
suggested changes
Mar 5, 2020
There was a problem hiding this comment.
Hi @ozonsozons,
Thanks for this PR.
${heap.dump.path} is not an ansible variable but a shell variable that can be used by Elasticsearch if defined.
According to jvm.options source, we should replace -XX:HeapDumpPath=${heap.dump.path} wich was the old way by ${heap.dump.path}. This way nothing appears in Elasticsearch process if this variable is empty.
Comment on lines
+113
to
+115
| {% if heap.dump.path is defined %} | ||
| -XX:HeapDumpPath=${heap.dump.path} | ||
| {% endif %} |
There was a problem hiding this comment.
Suggested change
| {% if heap.dump.path is defined %} | |
| -XX:HeapDumpPath=${heap.dump.path} | |
| {% endif %} | |
| ${heap.dump.path} |
|
We will finally add a new Ansible variable |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
heap.dump.path is set as mandatory variable.
Currently, if heap.dump.path is not defined then after deployment in linux it appears as "-XX:HeapDumpPath=${heap.dump.path}" in elastic+ process
Setting it to optional if defined.