Skip to content

Conversation

TomPridham
Copy link
Contributor

@TomPridham TomPridham commented Sep 26, 2019

fixed some relative links to different docs. i also changed the docs in the BulkErrorsResponse section to more explicitly call out the method required to get BulkErrorsResponse as the return type from the client

@mwilliammyers
Copy link
Collaborator

Hey @TomPridham! Thanks for the PR! I have been meaning to cleanup those links for a while. 👍🏼

Any chance you could fix those doc-test compilation errors when you get a chance, so we can merge this in?

@TomPridham
Copy link
Contributor Author

yeah, sure. is that just cargo test --doc?

@mwilliammyers
Copy link
Collaborator

mwilliammyers commented Sep 27, 2019

That would work to test just the doc tests or cargo test also includes them.

Is there a reason you got rid of the (hidden) do_request() functions in the docs? That is causing the issues...

@mwilliammyers
Copy link
Collaborator

Thanks for the PR!

@mwilliammyers mwilliammyers merged commit deb71ae into elastic-rs:master Sep 29, 2019
@TomPridham TomPridham deleted the chore/docs branch September 30, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants