Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41d571f1ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!isVisible || focusRequestVersion === 0) { | ||
| return; |
There was a problem hiding this comment.
This new guard means terminal focus only happens after requestTerminalFocus() increments focusRequestVersion, but the keyboard shortcut path still toggles the panel through usePanelShortcuts with the raw handleToggleTerminal callback (src/features/app/hooks/useLayoutController.ts:64-69) and never sends that focus request. After this change, opening the terminal via the configured shortcut can leave input focus outside xterm (especially on Windows), so typing does nothing until the user manually clicks the terminal.
Useful? React with 👍 / 👎.
1 participant
No description provided.