Skip to content

Commits from old repo and finished 2 TODOs #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AnonymousBluejay
Copy link

rotateVector() in VectorUtils may be a bit more optimized now
documented Nautilus particle

NathanWolf and others added 4 commits January 13, 2021 12:00
This fixes a security vulnerability in this project where the `pom.xml`
files were configuring Maven to resolve dependencies over HTTP instead of
HTTPS.

Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>

Co-authored-by: Nathan Wolf <NathanWolf@users.noreply.github.com>
@AnonymousBluejay
Copy link
Author

Just realized the note about moving to fork probably isn't needed here

@NathanWolf
Copy link
Member

Thank you!

So regarding the TODO:

Having some strange behavior up there.. Have to look in it later. TODO

Did you se and resolve the strange behavior? I honestly don't remember at all what was going on with this.

@AnonymousBluejay
Copy link
Author

I'm not entirely sure where the original commented code came from, I just changed it to apply rotations in order.

@PikaMug
Copy link

PikaMug commented Dec 28, 2022

The original code on April 25, 2014 was:

public static final Vector rotateVector(Vector v, double angleX, double angleY, double angleZ) {
rotateAroundAxisX(v, angleX);
rotateAroundAxisY(v, angleY);
rotateAroundAxisZ(v, angleZ);
return v;
}

The experimental code and TODO were added the next day in bfb9bec already commented out, so it was never implemented. Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants