Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 20, 2026

What does this PR do?

Promotes AsyncMinHashLSH from experimental to stable API with new import path datasketch.aio. Old imports remain functional with deprecation warnings.

New structure:

  • datasketch/aio/ - New submodule containing AsyncMinHashLSH, AsyncMinHashLSHInsertionSession, AsyncMinHashLSHDeleteSession
  • datasketch/__init__.py - Optional export (gracefully handles missing motor/redis dependencies)
  • datasketch/experimental/aio/ - Deprecated shim with warnings, re-exports from new location
  • pyproject.toml - Renamed dependency group experimental_aioaio (kept alias)

Import paths:

# New (recommended)
from datasketch.aio import AsyncMinHashLSH
from datasketch import AsyncMinHashLSH  # requires motor or redis.asyncio

# Old (deprecated, emits DeprecationWarning)
from datasketch.experimental.aio import AsyncMinHashLSH

Changes:

  • Updated all documentation references (docs/lsh.rst, docs/documentation.rst) to use datasketch.aio
  • Removed "experimental" designation from async LSH documentation
  • Fixed RedisStorage import to be conditional (optional dependency handling)
  • Updated tests to use new import path
  • Added clarifying comments for optional dependency patterns

Checklist

  • Are unit tests passing?
  • Documentation added/updated for all public APIs?
  • Is this a breaking change? If yes, add "[BREAKING]" to the PR title.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits January 20, 2026 18:33
Co-authored-by: ekzhu <320302+ekzhu@users.noreply.github.com>
Co-authored-by: ekzhu <320302+ekzhu@users.noreply.github.com>
Copilot AI changed the title [WIP] Move AsyncMinHashLSH from experimental to datasketch.aio Move AsyncMinHashLSH from experimental to datasketch.aio Jan 20, 2026
Copilot AI requested a review from ekzhu January 20, 2026 18:36
@ekzhu ekzhu marked this pull request as ready for review January 20, 2026 18:45
@ekzhu ekzhu merged commit d5248ca into move-async-api-to-main Jan 20, 2026
@ekzhu ekzhu deleted the copilot/sub-pr-301 branch January 20, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants