Skip to content

Conversation

@sarang-pratham
Copy link
Contributor

Summary
This PR modernizes the project’s Python packaging and dependency management using uv
. It replaces legacy setup.py and requirements.txt handling with a clean pyproject.toml config.

Changes

  • Migrated metadata and dependencies from setup.py to pyproject.toml
  • Consolidated optional dependencies under [project.optional-dependencies]
  • Verified compatibility by running all test suites (pytest)

Notes

Verified locally with:

uv sync --all-extras
uv run pytest

147 passed, 31 skipped, 4 warnings

@ekzhu ekzhu requested a review from Copilot November 4, 2025 19:55
@ekzhu
Copy link
Owner

ekzhu commented Nov 4, 2025

@bhimrazy could you work with @sarang-pratham here to review this PR?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the Python packaging configuration by migrating from setup.py to the PEP 517-compliant pyproject.toml format and adds documentation for the uv build system.

  • Replaced legacy setup.py with declarative pyproject.toml configuration
  • Added .python-version file specifying Python 3.13
  • Documented development setup using uv in README

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

File Description
setup.py Simplified to minimal shim calling setup() with configuration now in pyproject.toml
pyproject.toml New declarative package configuration with all metadata, dependencies, and optional extras
README.rst Added development setup instructions for using uv build system
.python-version Specifies Python 3.13 as the default version for development

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bhimrazy
Copy link
Contributor

bhimrazy commented Nov 5, 2025

@bhimrazy could you work with @sarang-pratham here to review this PR?

Sure @ekzhu

@bhimrazy
Copy link
Contributor

bhimrazy commented Nov 5, 2025

@ekzhu, I was wondering if it would be possible to grant edit permissions. With that, I can run the CI and make the necessary changes as well.

@ekzhu
Copy link
Owner

ekzhu commented Nov 5, 2025

@ekzhu, I was wondering if it would be possible to grant edit permissions. With that, I can run the CI and make the necessary changes as well.

I am figuring out the permission system for GitHub personal projects -- it is not as fine-grained as I'd like. Currently, once a user contributed to the repo, the CI will automatically run for that user. So in case this PR gets stalled you can start another PR and the CI will run okay.

@sarang-pratham sarang-pratham requested a review from ekzhu as a code owner November 6, 2025 15:49
@sarang-pratham
Copy link
Contributor Author

@ekzhu @bhimrazy
I was thinking if this https://github.com/nektos/act is something you guys would recommend using to test gh actions locally before pushing ?

@bhimrazy
Copy link
Contributor

bhimrazy commented Nov 6, 2025

Hi @sarang-pratham, I’ve opened another PR (#271) so that the CI can run and the changes can be properly tested. I’ve also included your commits there.

It’s (#271) quite a big one though — not sure if @ekzhu will like it.

@sarang-pratham
Copy link
Contributor Author

Hi @sarang-pratham, I’ve opened another PR (#271) so that the CI can run and the changes can be properly tested. I’ve also included your commits there.

It’s quite a big one though — not sure if @ekzhu will like it.

Okay, so this Open PR might not be relevant anymore - can we decline / close this ? @bhimrazy

cc: @ekzhu

@ekzhu
Copy link
Owner

ekzhu commented Nov 7, 2025

Thanks. I will close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants