-
Notifications
You must be signed in to change notification settings - Fork 315
Migrate build system to pyproject.toml and uv #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate build system to pyproject.toml and uv #254
Conversation
|
@bhimrazy could you work with @sarang-pratham here to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes the Python packaging configuration by migrating from setup.py to the PEP 517-compliant pyproject.toml format and adds documentation for the uv build system.
- Replaced legacy
setup.pywith declarativepyproject.tomlconfiguration - Added
.python-versionfile specifying Python 3.13 - Documented development setup using
uvin README
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| setup.py | Simplified to minimal shim calling setup() with configuration now in pyproject.toml |
| pyproject.toml | New declarative package configuration with all metadata, dependencies, and optional extras |
| README.rst | Added development setup instructions for using uv build system |
| .python-version | Specifies Python 3.13 as the default version for development |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sure @ekzhu |
|
@ekzhu, I was wondering if it would be possible to grant edit permissions. With that, I can run the CI and make the necessary changes as well. |
I am figuring out the permission system for GitHub personal projects -- it is not as fine-grained as I'd like. Currently, once a user contributed to the repo, the CI will automatically run for that user. So in case this PR gets stalled you can start another PR and the CI will run okay. |
|
@ekzhu @bhimrazy |
|
Hi @sarang-pratham, I’ve opened another PR (#271) so that the CI can run and the changes can be properly tested. I’ve also included your commits there.
|
Okay, so this Open PR might not be relevant anymore - can we decline / close this ? @bhimrazy cc: @ekzhu |
|
Thanks. I will close this one. |
Summary
This PR modernizes the project’s Python packaging and dependency management using uv
. It replaces legacy setup.py and requirements.txt handling with a clean pyproject.toml config.
Changes
Notes
Verified locally with:
147 passed, 31 skipped, 4 warnings