Skip to content

Disable eks-pod-identity-agent check in case of EKS auto mode #8345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TarmoKople
Copy link

Description

Fixes the error:

eksctl create podidentityassociation  .....            
Error: the "eks-pod-identity-agent" addon must be installed to create pod identity associations; please enable it using `eksctl ....

eksctl does not check whether EKS is using auto-mode or not. In EKS auto-mode, there is no need to check whether the eks-pod-identity-agent is installed or not, because eks-pod-identity-agent is part of the EKS auto-mode.
I added a check to the IsPodIdentityAgentInstalled function that verifies if the EKS cluster is using auto-mode and, if necessary, skips the check for the eks-pod-identity-agent.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello TarmoKople 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@cheeseandcereal
Copy link
Member

Thanks for the change! This solution seems reasonable to me, but this change is breaking unit tests. Can you fix the unit tests?

@TarmoKople
Copy link
Author

Thanks for the change! This solution seems reasonable to me, but this change is breaking unit tests. Can you fix the unit tests?

Yes, I'm going to fix the unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants