Skip to content

Remove deprecated "set-public-access-cidrs" integration tests #8311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 0 additions & 61 deletions integration/tests/crud/creategetdelete_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -500,67 +500,6 @@ var _ = Describe("(Integration) Create, Get, Scale & Delete", func() {
})
})

Context("configuring K8s API", Serial, Ordered, func() {
var (
k8sAPICall func() error
)

BeforeAll(func() {
cfg := makeClusterConfig()

ctl, err := eks.New(context.TODO(), &api.ProviderConfig{Region: params.Region}, cfg)
Expect(err).NotTo(HaveOccurred())

err = ctl.RefreshClusterStatus(context.Background(), cfg)
Expect(err).ShouldNot(HaveOccurred())

clientSet, err := ctl.NewStdClientSet(cfg)
Expect(err).ShouldNot(HaveOccurred())

k8sAPICall = func() error {
_, err = clientSet.CoreV1().ServiceAccounts(metav1.NamespaceDefault).List(context.TODO(), metav1.ListOptions{})
return err
}
})

AfterAll(func() {
// When the disable public access test below fails, the re-enable public access test is skipped so the
// cluster is left in a state where the API server is unreachable. This causes some of the tests later
// to fail as well. To avoid this, we need to re-enable public access here so calls to the API
// server can be made in subsequent tests.
Expect(params.EksctlUtilsCmd.WithArgs(
"set-public-access-cidrs",
"--cluster", params.ClusterName,
"0.0.0.0/0",
"--approve",
)).To(RunSuccessfully())
})

It("should have public access by default", func() {
Expect(k8sAPICall()).ShouldNot(HaveOccurred())
})

It("should disable public access", func() {
Expect(params.EksctlUtilsCmd.WithArgs(
"set-public-access-cidrs",
"--cluster", params.ClusterName,
"1.1.1.1/32,2.2.2.0/24",
"--approve",
)).To(RunSuccessfully())
Eventually(k8sAPICall, "5m", "20s").Should(HaveOccurred())
})

It("should re-enable public access", func() {
Expect(params.EksctlUtilsCmd.WithArgs(
"set-public-access-cidrs",
"--cluster", params.ClusterName,
"0.0.0.0/0",
"--approve",
)).To(RunSuccessfully())
Expect(k8sAPICall()).ShouldNot(HaveOccurred())
})
})

Context("configuring Cloudwatch logging", Serial, Ordered, func() {
var (
cfg *api.ClusterConfig
Expand Down
Loading