Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting the use of kubernetesUsername while creating an access entry #8223

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jolivataws
Copy link

@jolivataws jolivataws commented Feb 18, 2025

Description

The intention of this change is to document that it is possible to specify the kubernetesUsername field while creating an access entry.

Currently there are no reference to the parameter which currently is leading to the users to believe that this capability is not available for the eksctl.

I have modified the example provided that it is given to the users to showcase that the use of the field is possible.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • [] (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • [] Backfilled missing tests for code in same general area 🎉
  • [] Refactored something and made the world a better place 🌟

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello jolivataws 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@@ -21,6 +21,7 @@ accessConfig:
kubernetesGroups: # optional Kubernetes groups
- group1 # groups can used to give permissions via RBAC
- group2
kubernetesUsername: username # optional Kubernetes username
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are just examples, but the config schema does show/document this option https://eksctl.io/usage/schema/#accessConfig-accessEntries-kubernetesUsername

@github-actions github-actions bot added the stale label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants