Lookup instance availability for all AZs #5454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com>
Skarlso
commented
Jun 22, 2022
| @@ -1041,7 +1041,10 @@ func (n *NodeGroup) InstanceTypeList() []string { | |||
| if HasMixedInstances(n) { | |||
| return n.InstancesDistribution.InstanceTypes | |||
| } | |||
| return []string{n.InstanceType} | |||
| if n.InstanceType != "" { | |||
There was a problem hiding this comment.
These were the reason for the need to revert and the reason the tests failed.
#5453
Skarlso
commented
Jun 22, 2022
| @@ -1523,7 +1529,7 @@ func (m *ManagedNodeGroup) InstanceTypeList() []string { | |||
| if len(m.InstanceTypes) > 0 { | |||
| return m.InstanceTypes | |||
| } | |||
| return []string{m.InstanceType} | |||
| return nil | |||
|
Will link test run results of the two failing tests. |
Skarlso
commented
Jun 22, 2022
|
|
cPu1
approved these changes
Jul 1, 2022
|
Unit tests are failing after pulling in the latest changes, we're going to have to skip this for today's release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #5128
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯