Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the build flow for actions which use the eksctl build container #5424

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Fix the build flow for actions which use the eksctl build container #5424

merged 3 commits into from
Jun 16, 2022

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Jun 14, 2022

Description

Closes #5403

Please read the attached ticket's log to understand what's going on.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Himangini
Himangini approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Skarlso Skarlso merged commit c53796b into main Jun 16, 2022
@Skarlso Skarlso deleted the fix-checkout-flow branch June 16, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

@Himangini Himangini Himangini approved these changes

@nikimanoledaki nikimanoledaki Awaiting requested review from nikimanoledaki

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Fix the docker image build flow
3 participants
@Skarlso @cPu1 @Himangini