Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved example and updated error message regarding taints #5367

Merged
merged 4 commits into from
Jun 7, 2022
Merged

Improved example and updated error message regarding taints #5367

merged 4 commits into from
Jun 7, 2022

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Jun 2, 2022 •
edited
Loading

Description

Closes #5338

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Skarlso Skarlso added kind/feature New feature or request kind/docs User documentation labels Jun 2, 2022
cPu1
cPu1 approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

nikimanoledaki
nikimanoledaki approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Skarlso Skarlso merged commit b25d66a into eksctl-io:main Jun 7, 2022
@Skarlso Skarlso deleted the improve-taint-examples branch June 7, 2022 14:41
@Himangini Himangini added kind/improvement and removed kind/feature New feature or request labels Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

@nikimanoledaki nikimanoledaki nikimanoledaki approved these changes

@Himangini Himangini Awaiting requested review from Himangini

Assignees
No one assigned
Labels
kind/docs User documentation kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Quality of life improvments for new users applying taints
4 participants
@Skarlso @cPu1 @nikimanoledaki @Himangini