Add tolerations for taints on NVIDIA specific node groups#5345
Merged
Conversation
Contributor
Author
|
With the following config file: apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig
metadata:
name: gb-test-cluster-1
region: us-west-2
version: '1.22'
nodeGroups:
- name: ng-1
minSize: 1
maxSize: 2
desiredCapacity: 1
instanceType: p2.xlarge
taints:
feaster: "true:NoSchedule"
Achieved this on the nvidia pod: And the pod is successfully scheduled on the node: |
cPu1
reviewed
May 31, 2022
cPu1
reviewed
May 31, 2022
Contributor
Yes, the approach does look right to me 🙂 |
cPu1
approved these changes
Jun 1, 2022
Himangini
reviewed
Jun 1, 2022
Contributor
Author
|
Right, that didn't happen because there aren't any. :D |
Himangini
approved these changes
Jun 1, 2022
Contributor
Himangini
left a comment
There was a problem hiding this comment.
👍🏻
At some point, we should add some tickets to improve testing around this and taints in general 💡
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #5277
I believe this will do the trick, but I have to manually test it first. Is this right, @cPu1? I'm a bit unfamiliar with this part of the code. :)
TODO:
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯