-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tolerations for taints on NVIDIA specific node groups #5345
Conversation
With the following config file: apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig
metadata:
name: gb-test-cluster-1
region: us-west-2
version: '1.22'
nodeGroups:
- name: ng-1
minSize: 1
maxSize: 2
desiredCapacity: 1
instanceType: p2.xlarge
taints:
feaster: "true:NoSchedule"
Achieved this on the nvidia pod:
And the pod is successfully scheduled on the node:
|
Yes, the approach does look right to me 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extend unit tests
I can't see this in the files diff, where is this added? 🤔
Right, that didn't happen because there aren't any. :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
At some point, we should add some tickets to improve testing around this and taints in general 💡
Description
Closes #5277
I believe this will do the trick, but I have to manually test it first. Is this right, @cPu1? I'm a bit unfamiliar with this part of the code. :)
TODO:
Checklist
README.md
, or theuserdocs
directory)area/nodegroup
) and kind (e.g.kind/improvement
)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯