Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows IPAM #4356

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Add support for Windows IPAM #4356

merged 1 commit into from
Nov 10, 2021

Conversation

cPu1
Copy link
Contributor

@cPu1 cPu1 commented Oct 21, 2021

Description

This changelist adds support for Windows IPAM for new clusters.

EKS will eliminate the need to install the VPC controller on worker nodes to run Windows clusters for new clusters. For existing clusters, this functionality will be available later. When it's out, eksctl will

  1. Add a new flag --delete to eksctl utils install-vpc-controllers to allow deleting an existing installation of VPC controller
  2. Automatically patch the ConfigMap to enable Windows IPAM support when a Windows nodegroup is created

Partially addresses #2401

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cPu1 cPu1 added the kind/feature New feature or request label Oct 21, 2021
@cPu1 cPu1 force-pushed the windows-ipam branch 3 times, most recently from b457994 to 1b555e5 Compare October 21, 2021 14:31
@cPu1 cPu1 self-assigned this Nov 8, 2021
@cPu1 cPu1 force-pushed the windows-ipam branch 2 times, most recently from 05cda82 to 77de3fb Compare November 10, 2021 08:56
@cPu1
Copy link
Contributor Author

cPu1 commented Nov 10, 2021

I can confirm this feature is live. I'm going to merge after the integration test passes.

@cPu1 cPu1 merged commit 5d8d2e7 into eksctl-io:main Nov 10, 2021
@cPu1
Copy link
Contributor Author

cPu1 commented Nov 10, 2021

Integration test passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants