-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List supported k8s versions #2126
List supported k8s versions #2126
Conversation
This change was made to list the EKS Server Supported Versions. Added the functionality for eksctl version command to show the EKS server supported versions in a new line. Issue eksctl-io#2040
This change was made to list the EKS Server Supported Versions. Added the functionality for eksctl version command to show the EKS server supported versions in a new line. Issue eksctl-io#2040
…tripathy/eksctl into List-Supported-K8s-Versions Remote was ahead of local environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @smrutiranjantripathy , thank you for contributing to eksctl.
I have taken a quick look and the code looks great but I realized that this will likely break our automation since it expects to have only the version of eksclt printed when running eksctl vesion
.
I think we could either only print it when the output is formatted as json or not have this feature at all since it is already documented in the very first page of the website here.
What do you think?
Hi @martina-if , thanks for your review and feedback. :) I am guessing that you are pointing to the test files which might break. I checked make test build and go test command in the same directory, they were working fine. Is there any other flow in the release flow which I’m missing. I’m curious to know about the automation. Can you point me in that direction just for my knowledge. That would be great. I will change it to output in json. |
Hi @smrutiranjantripathy yes, you can see an example here |
Thanks @martina-if for pointing me to it. I have updated the PR. Kindly take a look at it and let me know if further changes are required. The output will look like this
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually tested it too and it looks good 👍 Thanks for the PR!
Fixes #2040
Description
First time contributor here!
Modified versioncmd to display EKS Supported Versions.
Modified Info Struct to include EKS Supported Versions.
Checklist
README.md
, or theuserdocs
directory)area/nodegroup
), target version (e.g.version/0.12.0
) and kind (e.g.kind/improvement
)