Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List supported k8s versions #2126

Merged

Conversation

smrutiranjantripathy
Copy link
Contributor

@smrutiranjantripathy smrutiranjantripathy commented May 3, 2020

Fixes #2040

Description

First time contributor here!

Modified versioncmd to display EKS Supported Versions.
Modified Info Struct to include EKS Supported Versions.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • [Y] Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • [Y] Make sure the title of the PR is a good description that can go into the release notes

This change was made to list the EKS Server Supported Versions. Added the functionality for eksctl version command to show the EKS server supported versions in a new line.

Issue eksctl-io#2040
This change was made to list the EKS Server Supported Versions. Added the functionality for eksctl version command to show the EKS server supported versions in a new line.

Issue eksctl-io#2040
…tripathy/eksctl into List-Supported-K8s-Versions

Remote was ahead of local environment.
Copy link
Contributor

@martina-if martina-if left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @smrutiranjantripathy , thank you for contributing to eksctl.

I have taken a quick look and the code looks great but I realized that this will likely break our automation since it expects to have only the version of eksclt printed when running eksctl vesion.

I think we could either only print it when the output is formatted as json or not have this feature at all since it is already documented in the very first page of the website here.

What do you think?

@smrutiranjantripathy
Copy link
Contributor Author

smrutiranjantripathy commented May 11, 2020

Hi @smrutiranjantripathy , thank you for contributing to eksctl.

I have taken a quick look and the code looks great but I realized that this will likely break our automation since it expects to have only the version of eksclt printed when running eksctl vesion.

I think we could either only print it when the output is formatted as json or not have this feature at all since it is already documented in the very first page of the website here.

What do you think?

Hi @martina-if , thanks for your review and feedback. :)

I am guessing that you are pointing to the test files which might break. I checked make test build and go test command in the same directory, they were working fine. Is there any other flow in the release flow which I’m missing. I’m curious to know about the automation. Can you point me in that direction just for my knowledge. That would be great. I will change it to output in json.

@martina-if
Copy link
Contributor

Hi @smrutiranjantripathy yes, you can see an example here

@smrutiranjantripathy
Copy link
Contributor Author

smrutiranjantripathy commented May 11, 2020

Hi @smrutiranjantripathy yes, you can see an example here

Thanks @martina-if for pointing me to it. I have updated the PR. Kindly take a look at it and let me know if further changes are required. The output will look like this

./eksctl version --output json
{"Version":"0.20.0","PreReleaseID":"dev","Metadata":{"BuildDate":"2020-05-11T21:02:36Z","GitCommit":"0243603e"},"EKSServerSupportedVersions":["1.13","1.14","1.15","1.16"]}

Copy link
Contributor

@martina-if martina-if left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually tested it too and it looks good 👍 Thanks for the PR!

@martina-if martina-if merged commit 0a04736 into eksctl-io:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Supported K8s Versions
2 participants