Filter only kops ec2 resource with type ec2.ResourceTypeSubnet #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to ensure that only resource with type ec2.ResourceTypeSubnet returns by ListSubnets get further processed When subnets carries AssociatedElasticIp or AssociatedNatgateway tag, ListSubnets function doesn't always return resources with ec2.ResourceTypeSubnet type These resources doesn’t have Obj property causing type conversion from nil into *ec2.Subnet to panic Issue eksctl-io#1410
|
Hi @rimaulana sorry that it took so long to get to this PR and thank you for contributing to eksctl! I think it looks good. Can you add in a comment some logs of when you manually tested this? Also, if you can rebase this we can merge it :) |
martina-if
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to ensure that only resource with type ec2.ResourceTypeSubnet
returned by ListSubnets get further processed
When subnets carries AssociatedElasticIp or AssociatedNatgateway tag,
ListSubnets function doesn't always return resources with
ec2.ResourceTypeSubnet type
These resources doesn’t have Obj property causing type conversion from
nil into *ec2.Subnet to panic
Issue #1410
Description
Checklist
README.md, andexamplesdirectory)area/nodegroup) and target version (e.g.version/0.12.0)docs/release_notes/draft.md(or relevant release note)