Disable zone filter, add flag to set zones manually #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errordeveloper
commented
Jul 20, 2018
| @@ -84,8 +84,8 @@ type AvailabilityZoneSelector struct { | |||
| func NewSelectorWithDefaults(ec2api ec2iface.EC2API) *AvailabilityZoneSelector { | |||
| avoidZones := map[string]bool{ | |||
| // well-known over-populated zones | |||
| "us-east-1a": true, | |||
| "us-east-1b": true, | |||
| // "us-east-1a": true, | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
errordeveloper
force-pushed
the
zones-flag
branch
from
5fc7bfa to
7c4cb26
Compare
This the only sane way to fix UnsupportedAvailabilityZoneException, espcially because it turns out that this is somehow different in every AWS account (at least that what seems to be the case from the docs. > You may receive an error that one of the Availability Zones in your > request does not have sufficient capacity to create an Amazon EKS > cluster. If this happens, the error output contains the Availability > Zones that can support a new cluster. Retry creating your cluster > with at least two subnets that are located in the supported > Availability Zones for your account. In the future we may try parsing the error message and retrying automatically, but it doesn't seem feasible right now as we would need to improve some of the internals and provide stack update functionality.
errordeveloper
force-pushed
the
zones-flag
branch
from
7c4cb26 to
b0d98bd
Compare
richardcase
approved these changes
Jul 23, 2018
| @@ -84,8 +84,8 @@ type AvailabilityZoneSelector struct { | |||
| func NewSelectorWithDefaults(ec2api ec2iface.EC2API) *AvailabilityZoneSelector { | |||
| avoidZones := map[string]bool{ | |||
| // well-known over-populated zones | |||
| "us-east-1a": true, | |||
| "us-east-1b": true, | |||
| // "us-east-1a": true, | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| @@ -74,6 +75,8 @@ func createClusterCmd() *cobra.Command { | |||
| fs.IntVarP(&cfg.MinNodes, "nodes-min", "m", 0, "minimum nodes in ASG") | |||
| fs.IntVarP(&cfg.MaxNodes, "nodes-max", "M", 0, "maximum nodes in ASG") | |||
|
|
|||
| fs.StringSliceVar(&availabilityZones, "zones", nil, "(auto-select if unspecified)") | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This the only sane way to fix UnsupportedAvailabilityZoneException,
espcially because it turns out that this is somehow different in every
AWS account (at least that what seems to be the case from the docs.
In the future we may try parsing the error message and retrying
automatically, but it doesn't seem feasible right now as we would
need to improve some of the internals and provide stack update
functionality.
Close #118. Finally.