Skip to content

feat(s3files): added support for s3files#965

Open
Lexy2 wants to merge 4 commits into
ekristen:mainfrom
Lexy2:feat/s3files
Open

feat(s3files): added support for s3files#965
Lexy2 wants to merge 4 commits into
ekristen:mainfrom
Lexy2:feat/s3files

Conversation

@Lexy2
Copy link
Copy Markdown

@Lexy2 Lexy2 commented May 29, 2026

Summary

Added support for s3files File Systems, Mount Targets & Access Points.

Test

Given the config:

resource-types:
    includes:
        - S3FilesFileSystem
        - S3FilesMountTarget
        - S3FilesAccessPoint

Dry-run

aws-nuke.exe run --config nuke-config.yaml
shows

starting scan for resources
ap-southeast-2 - S3FilesFileSystem - fs-0593eabdaf4fa6964 - [ID: "fs-0593eabdaf4fa6964"] - would remove
ap-southeast-2 - S3FilesMountTarget - fsmt-0fd00570f0c962e72 - [ID: "fsmt-0fd00570f0c962e72"] - would remove
ap-southeast-2 - S3FilesMountTarget - fsmt-0d1088b0ef7c81e15 - [ID: "fsmt-0d1088b0ef7c81e15"] - would remove
ap-southeast-2 - S3FilesAccessPoint - fsap-0403470a16e4a4f54 - [ID: "fsap-0403470a16e4a4f54"] - would remove
Scan complete: 4 total, 4 nukeable, 0 filtered.

Removal with filter

starting scan for resources
ap-southeast-2 - S3FilesFileSystem - fs-028de6bb13a9cb21f (FileSystemTag) - [ID: "fs-028de6bb13a9cb21f", Name: "FileSystemTag"] - would remove
ap-southeast-2 - S3FilesFileSystem - fs-0593eabdaf4fa6964 - [ID: "fs-0593eabdaf4fa6964"] - filtered: filtered by config
ap-southeast-2 - S3FilesMountTarget - fsmt-077fac25443f836bb - [FileSystemId: "fs-028de6bb13a9cb21f", ID: "fsmt-077fac25443f836bb"] - would remove
ap-southeast-2 - S3FilesMountTarget - fsmt-0c610ad37cb7c0e84 - [FileSystemId: "fs-028de6bb13a9cb21f", ID: "fsmt-0c610ad37cb7c0e84"] - would remove
ap-southeast-2 - S3FilesMountTarget - fsmt-0fd00570f0c962e72 - [FileSystemId: "fs-0593eabdaf4fa6964", ID: "fsmt-0fd00570f0c962e72"] - filtered: filtered by config
ap-southeast-2 - S3FilesMountTarget - fsmt-0d1088b0ef7c81e15 - [FileSystemId: "fs-0593eabdaf4fa6964", ID: "fsmt-0d1088b0ef7c81e15"] - filtered: filtered by config
ap-southeast-2 - S3FilesAccessPoint - fsap-0b338b68200c588dc - [FileSystemId: "fs-028de6bb13a9cb21f", ID: "fsap-0b338b68200c588dc"] - would remove
ap-southeast-2 - S3FilesAccessPoint - fsap-0403470a16e4a4f54 - [FileSystemId: "fs-0593eabdaf4fa6964", ID: "fsap-0403470a16e4a4f54"] - filtered: filtered by config
Scan complete: 8 total, 4 nukeable, 4 filtered.

Do you really want to nuke the account with the ID 828414849540 and the alias 'no-alias-828414849540'?
Do you want to continue? Enter account alias to continue.
> no-alias-828414849540

ap-southeast-2 - S3FilesFileSystem - fs-028de6bb13a9cb21f (FileSystemTag) - [ID: "fs-028de6bb13a9cb21f", Name: "FileSystemTag"] - failed
ap-southeast-2 - S3FilesMountTarget - fsmt-077fac25443f836bb - [FileSystemId: "fs-028de6bb13a9cb21f", ID: "fsmt-077fac25443f836bb"] - triggered remove
ap-southeast-2 - S3FilesMountTarget - fsmt-0c610ad37cb7c0e84 - [FileSystemId: "fs-028de6bb13a9cb21f", ID: "fsmt-0c610ad37cb7c0e84"] - triggered remove
ap-southeast-2 - S3FilesAccessPoint - fsap-0b338b68200c588dc - [FileSystemId: "fs-028de6bb13a9cb21f", ID: "fsap-0b338b68200c588dc"] - triggered remove
Removal requested: 3 waiting, 1 failed, 4 skipped, 0 finished


ap-southeast-2 - S3FilesFileSystem - fs-028de6bb13a9cb21f (FileSystemTag) - [ID: "fs-028de6bb13a9cb21f", Name: "FileSystemTag"] - failed
ap-southeast-2 - S3FilesMountTarget - fsmt-077fac25443f836bb - [FileSystemId: "fs-028de6bb13a9cb21f", ID: "fsmt-077fac25443f836bb"] - waiting for removal
ap-southeast-2 - S3FilesMountTarget - fsmt-0c610ad37cb7c0e84 - [FileSystemId: "fs-028de6bb13a9cb21f", ID: "fsmt-0c610ad37cb7c0e84"] - waiting for removal
ap-southeast-2 - S3FilesAccessPoint - fsap-0b338b68200c588dc - [FileSystemId: "fs-028de6bb13a9cb21f", ID: "fsap-0b338b68200c588dc"] - waiting for removal
Removal requested: 3 waiting, 1 failed, 4 skipped, 0 finished


ap-southeast-2 - S3FilesFileSystem - fs-028de6bb13a9cb21f (FileSystemTag) - [ID: "fs-028de6bb13a9cb21f", Name: "FileSystemTag"] - failed
ap-southeast-2 - S3FilesMountTarget - fsmt-077fac25443f836bb - [FileSystemId: "fs-028de6bb13a9cb21f", ID: "fsmt-077fac25443f836bb"] - waiting for removal
ap-southeast-2 - S3FilesMountTarget - fsmt-0c610ad37cb7c0e84 - [FileSystemId: "fs-028de6bb13a9cb21f", ID: "fsmt-0c610ad37cb7c0e84"] - waiting for removal
ap-southeast-2 - S3FilesAccessPoint - fsap-0b338b68200c588dc - [FileSystemId: "fs-028de6bb13a9cb21f", ID: "fsap-0b338b68200c588dc"] - removed
Removal requested: 2 waiting, 1 failed, 4 skipped, 1 finished


ap-southeast-2 - S3FilesFileSystem - fs-028de6bb13a9cb21f (FileSystemTag) - [ID: "fs-028de6bb13a9cb21f", Name: "FileSystemTag"] - triggered remove
ap-southeast-2 - S3FilesMountTarget - fsmt-077fac25443f836bb - [FileSystemId: "fs-028de6bb13a9cb21f", ID: "fsmt-077fac25443f836bb"] - removed
ap-southeast-2 - S3FilesMountTarget - fsmt-0c610ad37cb7c0e84 - [FileSystemId: "fs-028de6bb13a9cb21f", ID: "fsmt-0c610ad37cb7c0e84"] - removed
Removal requested: 1 waiting, 0 failed, 4 skipped, 3 finished


ap-southeast-2 - S3FilesFileSystem - fs-028de6bb13a9cb21f (FileSystemTag) - [ID: "fs-028de6bb13a9cb21f", Name: "FileSystemTag"] - waiting for removal
Removal requested: 1 waiting, 0 failed, 4 skipped, 3 finished


ap-southeast-2 - S3FilesFileSystem - fs-028de6bb13a9cb21f (FileSystemTag) - [ID: "fs-028de6bb13a9cb21f", Name: "FileSystemTag"] - removed
Removal requested: 0 waiting, 0 failed, 4 skipped, 4 finished


Nuke complete: 0 failed, 4 skipped, 4 finished.

@Lexy2 Lexy2 marked this pull request as draft May 29, 2026 10:19
@Lexy2 Lexy2 marked this pull request as ready for review May 29, 2026 20:58
@Lexy2 Lexy2 closed this May 30, 2026
@Lexy2
Copy link
Copy Markdown
Author

Lexy2 commented May 30, 2026

Broke branch with incorrect rebase

@Lexy2 Lexy2 deleted the feat/s3files branch May 30, 2026 03:40
@Lexy2 Lexy2 restored the feat/s3files branch May 30, 2026 03:49
@Lexy2
Copy link
Copy Markdown
Author

Lexy2 commented May 30, 2026

Phew, I restored the commits

@Lexy2 Lexy2 reopened this May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant