feat(s3tables): add support for s3tables#928
Open
roseo1 wants to merge 2 commits into
Open
Conversation
Owner
|
Please add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to add
s3tablesresources:Testing
With config:
And dry run:
Will be running not in dry-run from my snapshot build to verify over the next couple of days, happy to wait for the outcome of that before this is considered ready.
(some other contribution questions:
{region} - {resourcetype} - {name} [{properties...}]) is just because its not using the deprecatedString, or is that not expected?S3Objectfrom v4 is to be disabled by default and allowS3Bucketto empty and delete. Should this be the pattern S3TableBucket takes from the start? (namespace and table disabled and bucket delete removes all the child resources).ListTablesandListNamespacesdon't return the table bucket arn, so deleting them by default as part ofS3TableBucketwould reduce the annoying nested listing unless opted in)