Skip to content

feat(timestreaminfluxdb): add TimestreamInfluxDBDbInstance resource#890

Open
chrisns wants to merge 2 commits into
ekristen:mainfrom
chrisns:feat/timestreaminfluxdb-resource
Open

feat(timestreaminfluxdb): add TimestreamInfluxDBDbInstance resource#890
chrisns wants to merge 2 commits into
ekristen:mainfrom
chrisns:feat/timestreaminfluxdb-resource

Conversation

@chrisns
Copy link
Copy Markdown
Contributor

@chrisns chrisns commented Mar 2, 2026

Summary

Firstly, thank you for maintaining aws-nuke — it's an incredibly useful
tool and the codebase is a pleasure to contribute to.

This PR adds native support for Amazon Timestream for InfluxDB DB instances
(timestream-influxdb service, CloudFormation type
AWS::TimestreamInfluxDB::DbInstance), which currently has no coverage in
aws-nuke via Cloud Control or native resources.

  • Introduces TimestreamInfluxDBDbInstance with List, Remove, Filter,
    and Properties, following the RAM resource-share interface/mock pattern
  • Tags are fetched per-instance via ListTagsForResource and exposed as
    tag:KeyName for use in filters
  • Filter() skips instances already in DELETED or DELETING state to
    avoid unnecessary API errors
  • Includes 4 mock tests covering List (with pagination and tag fetching),
    Filter (table-driven across 4 statuses), Remove, and Properties

Adds native support for Amazon Timestream for InfluxDB DB instances
(timestream-influxdb service). Implements List, Remove, Filter, and
Properties following the RAM resource-share interface/mock pattern.
@ekristen
Copy link
Copy Markdown
Owner

ekristen commented Mar 2, 2026

@chrisns thanks for the contribution. My pleasure to continue maintaining the tool. Please address the golangci-lint errors.

@chrisns
Copy link
Copy Markdown
Contributor Author

chrisns commented Mar 2, 2026

Apologies for missing this — fixed the rangeValCopy gocritic lint error on line 47 by replacing for _, item := range resp.Items with the index pattern (for i := range resp.Items { item := &resp.Items[i]), consistent with the rest of the codebase. All mock tests still pass. Force-pushed to the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants