feat(timestreaminfluxdb): add TimestreamInfluxDBDbInstance resource#890
Open
chrisns wants to merge 2 commits into
Open
feat(timestreaminfluxdb): add TimestreamInfluxDBDbInstance resource#890chrisns wants to merge 2 commits into
chrisns wants to merge 2 commits into
Conversation
Adds native support for Amazon Timestream for InfluxDB DB instances (timestream-influxdb service). Implements List, Remove, Filter, and Properties following the RAM resource-share interface/mock pattern.
Owner
|
@chrisns thanks for the contribution. My pleasure to continue maintaining the tool. Please address the golangci-lint errors. |
Contributor
Author
|
Apologies for missing this — fixed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Firstly, thank you for maintaining aws-nuke — it's an incredibly useful
tool and the codebase is a pleasure to contribute to.
This PR adds native support for Amazon Timestream for InfluxDB DB instances
(
timestream-influxdbservice, CloudFormation typeAWS::TimestreamInfluxDB::DbInstance), which currently has no coverage inaws-nuke via Cloud Control or native resources.
TimestreamInfluxDBDbInstancewithList,Remove,Filter,and
Properties, following the RAM resource-share interface/mock patternListTagsForResourceand exposed astag:KeyNamefor use in filtersFilter()skips instances already inDELETEDorDELETINGstate toavoid unnecessary API errors
Filter (table-driven across 4 statuses), Remove, and Properties