-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat pg indonepal aeps #104
Feat pg indonepal aeps #104
Conversation
Release: Develop to Master
👷 Deploy request for ekobeta pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed part of your changes. See my comments in Github where you have raised pull request. Check the rest of your files as well to fix similar things.
src/_includes/navigation.njk
Outdated
@@ -31,7 +31,10 @@ | |||
<ul class="nested-sub-menu"> | |||
<li><a href="/eloka/insurance-portal">{% dotTag "Insurance Portal" %}</a></li> | |||
<li><a href="/eloka/recharge-portal">{% dotTag "Recharge Portal" %}</a></li> | |||
<li><a href="/eloka/travel-portal">{% dotTag "Travel Portal" %}</a></li> | |||
<li><a href="/eloka/travel-portal">{% dotTag "Traclvel Portal" %}</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong spelling
src/_includes/navigation.njk
Outdated
<li><a href="/eloka/travel-portal">{% dotTag "Travel Portal" %}</a></li> | ||
<li><a href="/eloka/travel-portal">{% dotTag "Traclvel Portal" %}</a></li> | ||
<li><a href="/eloka/aeps-portal">{% dotTag "AePS Portal" %}</a></li> | ||
<li><a href="/eloka/payment-gateway">{% dotTag "Payment Gateway Portal" %}</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is "Portal" not used in name & URL?
src/_includes/navigation.njk
Outdated
<li><a href="/eloka/travel-portal">{% dotTag "Traclvel Portal" %}</a></li> | ||
<li><a href="/eloka/aeps-portal">{% dotTag "AePS Portal" %}</a></li> | ||
<li><a href="/eloka/payment-gateway">{% dotTag "Payment Gateway Portal" %}</a></li> | ||
<li><a href="/eloka/indo-nepal-money-transfer">{% dotTag "Indo-Nepal Money Transfer Portal" %}</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is "Portal" not used in URL?
src/assets/img/PG/pg.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimise this image file. Too large.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimise the png files
src/eloka/aeps-portal.njk
Outdated
|
||
<h1>{{ product.sub_tag_line }}</h1> | ||
|
||
<p class="lh-high">Welcome to our B2B AePS Portal, your go-to platform for efficient, secure, and reliable Aadhaar-based payment solutions. Designed for businesses looking to offer seamless financial services, our portal empowers you to manage transactions with ease, expand your service offerings, and drive growth across your network.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Payment solutions" or "payments & cash-out solutions"?
src/eloka/aeps-portal.njk
Outdated
image: "/assets/img/developers/secure-icon.svg" | ||
}, | ||
{ | ||
title: "Additional free services", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not capitalized, unlike other titles?
src/eloka/aeps-portal.njk
Outdated
{ | ||
type: "pair", | ||
title_left: "Swift Onboarding", | ||
text_left: "Launch your brand effortlessly with our quick onboarding process, allowing you to Start your own AePS company within 10 minutes.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Start" in small case
src/eloka/aeps-portal.njk
Outdated
}, | ||
{ | ||
title: "Can I customize the portal with my branding?", | ||
description: "Yes, Eloka allows you to customize your portal with your own logo, colours, domain, app name, company name, etc." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove "company name"
src/eloka/aeps-portal.njk
Outdated
}, | ||
{ | ||
title: "Can I use my own domain?", | ||
description: "Yes, you can setup your own domain name for free!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not free
fix minor typos
fix minor typo
No description provided.