Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors the code into separate components #20

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sortigoza
Copy link

This refactors the code to have 4 separate components:

  • Config: parses and expose a consistent interface to read config values
  • GitHubDataProvider: encapsulates all the GitHub fetching and filtering logic
  • Formater: encapsulates all the text formatting logic
  • Slack: used to send message to slack

This makes it easier to add different notification services beside slack and different formatting

Also, it adds logging and a dockerfile.

Saul Ortigoza and others added 7 commits November 7, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant