Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle rocknroll correctly #39

Closed
mheiber opened this issue May 2, 2017 · 2 comments
Closed

handle rocknroll correctly #39

mheiber opened this issue May 2, 2017 · 2 comments

Comments

@mheiber
Copy link
Contributor

mheiber commented May 2, 2017 •
edited
Loading

Should be rock 'n' roll instead of rock ‘n’ roll. (see Markdown source for what I mean by this)

That is, the 'n' should have two apostrophes instead of an opening and single quote and closing smart quote
@mheiber
Copy link
Contributor Author

mheiber commented May 2, 2017

Happy to PR for this

@ekalinin
Copy link
Owner

ekalinin commented May 3, 2017

Hey @mheiber

Thanks for report.
Sure, PRs are very welcome :)

mheiber added a commit to mheiber/typogr.js that referenced this issue May 6, 2017
@mheiber
ekalinin#39 rock and roll aware
291b925 
Use two apostrophes for the 'n' in rock ’n’ roll.
mheiber added a commit to mheiber/typogr.js that referenced this issue May 6, 2017
@mheiber
ekalinin#39 rock and roll aware
411b449 
Use two apostrophes for the 'n' in rock ’n’ roll.
mheiber added a commit to mheiber/typogr.js that referenced this issue May 6, 2017
@mheiber
ekalinin#39 rock and roll aware
c19d145 
Use two apostrophes for the 'n' in rock ’n’ roll.
mheiber added a commit to mheiber/typogr.js that referenced this issue May 6, 2017
@mheiber
ekalinin#39 rock and roll aware
6dcb809 
Fix ekalinin#39

Use two apostrophes for the 'n' in rock ’n’ roll.
@mheiber mheiber mentioned this issue May 6, 2017
Merged
mheiber added a commit to mheiber/typogr.js that referenced this issue May 6, 2017
@mheiber
ekalinin#39 rock and roll aware
7cc88d1 
Fix ekalinin#39

Use two apostrophes for the 'n' in rock ’n’ roll.
ekalinin added a commit that referenced this issue May 10, 2017
@ekalinin
Merge pull request #40 from mheiber/39-rock-n-roll-aware
3785b50 
 #39 rock and roll aware
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ekalinin @mheiber