Conversation
CI was red on every run: make lint runs ruff then mypy --strict; ruff exited first with 5 errors, with 16 mypy errors behind it. Tests already passed (88/3 skipped) — this fixes the lint gate. Lint fixes: - ruff: datetime.UTC (UP017), drop unused imports (F401), dedup mock_aws (F811) - BaseReader.read Protocol: add deep + **_kwargs (fixes quicklook call-arg) - mypy overrides: add bare astropy + astropy.* + asdf (glob alone misses bare pkg) - asdf._to_plain: cast tree, getattr tag, drop stale type:ignore; AIDEV anchors + no-__iter__ invariant preserved - streams.readinto: type:ignore[override] (deliberately narrow, zero new dep) - browser: None guard before int(row_key.value); async action_back Workflows: - ci.yml: PR + push to main only (drop claude/**), permissions contents:read, ubuntu 3.11+3.12 full lint+test, macos 3.12 test-only (pyperclip divergence) - release.yml: trigger on release published; build -> publish-pypi via OIDC trusted publishing with mandatory download-artifact; non-blocking TestPyPI dry-run - docs/releasing.md: PyPI Trusted Publisher (OIDC) setup + version-burn rollback note Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI was failing on every run. Root cause = lint, not workflow config:
make lintrunsruffthenmypy --strict; ruff exited first with 5 errors, with 16 mypy errors behind it. Tests already passed. This repairs the lint gate and consolidates CI/CD to the two workflows requested.CI green
ruff check src tests→ All checks passedpython -m mypy src→ Success, 19 filesmake test→ 88 passed, 3 skippedLint fixes (5 ruff + 16 mypy → 0)
datetime.UTC(UP017), drop unused imports (F401), dedupmock_aws(F811)BaseReader.readProtocol: adddeep+**_kwargs(fixesquicklookcall-arg; impls already had them)astropy+astropy.*+asdf(glob alone misses the bare package)asdf._to_plain: cast tree,getattrtag, drop staletype: ignore— AIDEV anchors + no-__iter__recursion-bomb invariant preservedstreams.readinto:# type: ignore[override](deliberately narrow, zero new dep)browser: None guard beforeint(row_key.value);async def action_backWorkflows (one CI, one release)
mainonly (droppedclaude/**),permissions: contents:read, ubuntu 3.11+3.12 full lint+test, macos 3.12 test-only (pyperclippbcopy/xclip divergence on the core macOS user base)release: published;build → publish-pypivia OIDC Trusted Publishing with mandatorydownload-artifact(old file omitted it → would publish empty); non-blocking TestPyPI dry-run off the critical pathAction required after merge (one-time, manual)
PyPI Trusted Publisher must be registered before first release — see
docs/releasing.md:owner
ejoliet, repos3peek, workflow filenamerelease.yml, environmentpypi(+testpypi). Create matching GitHub Environments. No API token stored.Planned + reviewed via consensus (Architect + Critic), executed by a 2-agent team.
🤖 Generated with Claude Code