Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Window switcher lag #280

Merged
merged 2 commits into from
Aug 30, 2024
Merged

fix: Window switcher lag #280

merged 2 commits into from
Aug 30, 2024

Conversation

ejbills
Copy link
Owner

@ejbills ejbills commented Aug 30, 2024

Describe your changes

  • Fixes window switcher lag by lazily updating the window space cache rather than making the UI wait for the update to process
  • Fixes closed windows not being removed from cache

Related issue number(s) and link(s)

Closes #273

Checklist before requesting a review

  • I have performed a self-review of my code
  • If this change affects core functionality, I have added a description highlighting the changes
  • I have followed conventional commit guidelines

Core Functionality Changes

If this PR modifies core functionality, please provide a brief description of the changes and their impact below:

@ejbills ejbills merged commit e3821d9 into main Aug 30, 2024
5 checks passed
@ejbills ejbills deleted the window-switcher-lag branch August 30, 2024 20:34

// Check if we can get the window's size
var size: CFTypeRef?
let sizeResult = AXUIElementCopyAttributeValue(element, kAXSizeAttribute as CFString, &size)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ejbills Why not element.position(), element.size()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Window Switcher is way too slow
2 participants