Skip to content

Conversation

@eitsupi
Copy link
Owner

@eitsupi eitsupi commented Feb 8, 2026

Summary

  • Meta commands (:restart, :help, :cd, etc.) no longer leave the previous R command's duration in the prompt
  • Added clear_command_duration() method and call it in both REPL loops when a meta command is processed

Before:

R 4.5.2> Sys.sleep(2)
2s R 4.5.2> :restart    # ← "2s" persists
2s R 4.5.2>

After:

R 4.5.2> Sys.sleep(2)
2s R 4.5.2> :restart    # ← duration cleared
R 4.5.2>

Test plan

  • Run Sys.sleep(2), confirm 2s appears in prompt
  • Run :help, confirm duration is cleared
  • Run :restart (cancel with n), confirm duration is cleared
  • Run another R command, confirm new duration works correctly

🤖 Generated with Claude Code

Previously, the duration from the last R command persisted in the prompt
after executing meta commands like :restart, :help, :cd. Now the duration
is cleared whenever a meta command is processed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a prompt UX issue where the {duration} segment (showing the previous R command’s execution time) could incorrectly persist after executing REPL meta commands (e.g., :help, :restart).

Changes:

  • Added PromptRuntimeConfig::clear_command_duration() to reset stored command duration.
  • Invoked duration clearing after meta command processing in both the standalone REPL loop and the main R ReadConsole loop.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
crates/arf-console/src/repl/state.rs Adds a runtime-config helper to clear stored last-command duration so {duration} won’t render stale values.
crates/arf-console/src/repl/mod.rs Calls the new helper after meta command handling in both REPL input paths to prevent stale duration display.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@eitsupi eitsupi merged commit f439dab into main Feb 8, 2026
10 checks passed
@eitsupi eitsupi deleted the fix/clear-duration-on-meta-command branch February 8, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant