Repository navigation
Allow Inhomogeneous Measurement Patterns (Accelerate) - #88
Merged
Merged
Conversation
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
meas_matis a 3-dimensional ndarray which represents the excitation id and the differential pairs[n, m]. What if we want to combine the differential pairs ofadjacent(16 elctrodes, 13 measurements per exc) andopposite(16 electrodes, 12 measurements per exc) excitations?This PR implements a vstacked version os
meas_mat. Nowmeas_matis a 2-dimensional array, of sizen_meas x 3. Each column represents[n, m, exc_id].The benefit of using this type of measurement matrix is that:
subtract_row_vectorizedandsmear_ndand a much cleaner implementation of calculatingjac, see the code accordingly.The PR redesigns the measurement protocol
meas_mat, #46