Repository navigation
Add PyEITMesh, PyEITProtocol, PyEITAnomaly - #47
Merged
Merged
Conversation
- docstring
- add ref_el (chekc and set (for user)) - add prop n_el
- replace internal attribute by calling directly the date from the mesh object (e.g. self.mesh.node, etc) - now a lot of size of date can be accessed from self.mesh.... (beetr for pylance or u.a)
-remove used attributes - use data of mesh directly!
- Only replace the dict calls - some small corrections
- remove all usued attributes - in fem remove checks of data (less responsabiltity for fwd)
- use of the package warning to make non blocking warnings - fix some errors
- use the PyeitProtocol cls to build a protocol_obj using pyeit.eit.protocol.create wrapper function - pyeit.eit.protocol.create can accepe multiple el_dist (for stacked excitation) -add n_el in examples.. - rename eit_scan_lines (utils.py is now oselete, ... not used, ) to build_exc_pattern_std
- correct error in set_perm (d was not diamerter but r...)
1 of 2 tasks
This was referenced May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hy @liubenyuan,
I added PyEITMesh, PyEITProtocol, PyEITAnomaly.
now
Forward,EITforwardandEITbaseare much better, and have less responsabilities, I could move the data checking in the dataclass directly, also by creating some usefull properties we can use them directly in the code and it is more understandable from where the data are coming from (e.g self.mesh.node or self.mesh.n_elems).just for fun I added PyEITAnomaly abc class now your anomaly are based on your shape functions! (in the future you can than implememt more complexe anomaly or with other shape!)
I tested all examples run!
I will modify my custom software to use that version of pyEIT (maybe i will found other errors...)