Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the drawing #21

Merged
merged 16 commits into from
Oct 5, 2024
Merged

Refactor the drawing #21

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e4b65c4
Rename `CanvasBezierCurvePoints` to `BezierCurvePoints`
eisukekusachi Oct 1, 2024
eba84a3
Rename `CanvasFirstBezierCurvePoints` to `BezierCurveFirstPoints`
eisukekusachi Oct 1, 2024
938b7e1
Rename `CanvasLastBezierCurvePoints` to `BezierCurveLastPoints`
eisukekusachi Oct 1, 2024
a7c1baf
Rename `CanvasGrayscaleCurveIterator` methods
eisukekusachi Oct 5, 2024
09c18d5
Add methods to create Bezier curve points in `CanvasGrayscaleDotPoint`
eisukekusachi Oct 5, 2024
0e87459
Add `var isNoFirstCurveDrawn` to `class CanvasGrayscaleCurveIterator`
eisukekusachi Oct 5, 2024
9c315c6
Use `CanvasGrayscaleDotPoint.makeCurvePoints` instead of `grayscaleTe…
eisukekusachi Oct 5, 2024
95b4f3e
Fix `CanvasGrayscaleCurveIteratorTests`
eisukekusachi Oct 5, 2024
e76bdec
Rename `BezierCurvePoints.swift` to `CanvasBezierCurvePoints.swift`
eisukekusachi Oct 5, 2024
6e89641
Rename `Drawing` to `BezierCurve`
eisukekusachi Oct 5, 2024
ed3c197
Rename methods
eisukekusachi Oct 5, 2024
27f61f1
Rename methods and variables
eisukekusachi Oct 5, 2024
55b5fa8
Rename methods
eisukekusachi Oct 5, 2024
0cf7f61
Modify the comments
eisukekusachi Oct 5, 2024
abfa6e0
Rename `getBezierCurveIntermediateHandlePoints` to `getIntermediateBe…
eisukekusachi Oct 5, 2024
750e70a
Rename `CanvasGrayscaleTexturePointIterator` to `CanvasGrayscaleCurve…
eisukekusachi Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix CanvasGrayscaleCurveIteratorTests
  • Loading branch information
@eisukekusachi
eisukekusachi committed Oct 5, 2024
commit 95b4f3ededd45fbb3467c1125c39b751b612b7db
40 changes: 28 additions & 12 deletions ...leApplePencilDrawingTests/Views/CanvasView/Models/CanvasGrayscaleCurveIteratorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,16 @@ final class CanvasGrayscaleCurveIteratorTests: XCTestCase {

if let result, let expectation = expectation.result {
XCTAssertEqual(
[result.previousPoint.location, result.startPoint.location, result.endPoint.location],
[expectation.previousPoint.location, expectation.startPoint.location, expectation.endPoint.location]
[
result.previousPoint,
result.startPoint,
result.endPoint
],
[
expectation.previousPoint,
expectation.startPoint,
expectation.endPoint
]
)
} else {
XCTAssertNil(result)
Expand Down Expand Up @@ -183,16 +191,16 @@ final class CanvasGrayscaleCurveIteratorTests: XCTestCase {
let expectation = expectationArray[i]
XCTAssertEqual(
[
result.previousPoint.location,
result.startPoint.location,
result.endPoint.location,
result.nextPoint.location
result.previousPoint,
result.startPoint,
result.endPoint,
result.nextPoint
],
[
expectation.previousPoint.location,
expectation.startPoint.location,
expectation.endPoint.location,
expectation.nextPoint.location
expectation.previousPoint,
expectation.startPoint,
expectation.endPoint,
expectation.nextPoint
]
)
}
Expand Down Expand Up @@ -257,8 +265,16 @@ final class CanvasGrayscaleCurveIteratorTests: XCTestCase {

if let result, let expectation = expectation.result {
XCTAssertEqual(
[result.previousPoint.location, result.startPoint.location, result.endPoint.location],
[expectation.previousPoint.location, expectation.startPoint.location, expectation.endPoint.location]
[
result.previousPoint,
result.startPoint,
result.endPoint
],
[
expectation.previousPoint,
expectation.startPoint,
expectation.endPoint
]
)
} else {
XCTAssertNil(result)
Expand Down