Call Validate() when unmarshalling resource name #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikaverpil
force-pushed
the
tra-1296-call-validate
branch
from
59bc82d
to
9a702a7
Compare
fredrikaverpil
changed the title
fredrikaverpil
changed the title
thall
reviewed
Apr 10, 2024
cmd/protoc-gen-go-aip/internal/genaip/testdata/test/multipattern/testdata_aip.go
Outdated
Show resolved
Hide resolved
odsod
reviewed
Apr 10, 2024
fredrikaverpil
force-pushed
the
tra-1296-call-validate
branch
from
9a702a7
to
505461a
Compare
thall
reviewed
Apr 11, 2024
| if err != nil { | ||
| return err | ||
| } | ||
| if err := n.Validate(); err != nil { |
There was a problem hiding this comment.
You could return the error directly.
return n.Validate()
There was a problem hiding this comment.
oh, nice - great suggestion, and so obvious now that I realize the return signature is identical!
fredrikaverpil
force-pushed
the
tra-1296-call-validate
branch
from
505461a
to
de5dc16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are calling
Validate()on marshalling but not on unmarshalling a resource name. This PR fixes that.