Skip to content

fix: Reviewer Disposition dark-mode contrast + registry manifest hash refresh #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
munkyukim86 merged 2 commits into from
Jul 24, 2026
Merged

fix: Reviewer Disposition dark-mode contrast + registry manifest hash refresh #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d586342
fix: dark mode contrast in Reviewer Disposition + registry manifest h…
munkyukim86 Jul 24, 2026
60ebeb5
fix: remaining dark-mode gaps found in full-page audit
munkyukim86 Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion reproducibility/benchmark_v0.5.1/MANIFEST.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
},
"parameter_registry": {
"path": "src/factorforge/registry/current_parameter_registry.yaml",
"sha256": "1cc163faa5a5be118b0d221a63a93a1241f1f9d82d85ab6d4c627c8988b0542a"
"sha256": "64fd2f9de792b215ce257c8300e01cb1d86765f0a726740a8893aee6d8dff5e6"

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin the evidence manifest to the frozen registry

When reproducing benchmark_v0.5.1, this checksum now verifies the current src/factorforge/registry/current_parameter_registry.yaml blob, whose registry version is 3.4.1, while the evidence pack itself still advertises FactorForge/registry 3.2.0 in reproducibility/benchmark_v0.5.1/README.md:13-15. Because the current registry has since changed benchmark-relevant defaults such as the N. benthamiana GC band and codon reference, the manifest can pass while proving the wrong registry for the v3.2.0 results; keep this input pinned to the actual frozen v3.2.0 registry artifact instead of refreshing it to HEAD.

Useful? React with 👍 / 👎.

}
},
"outputs": {
Expand Down
16 changes: 8 additions & 8 deletions web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ <h2 class="text-lg font-extrabold flex items-center text-slate-900">
<div class="relative group">
<input type="file" id="fileUpload" accept=".fasta,.fa,.txt" class="hidden">
<label for="fileUpload"
class="flex flex-col items-center justify-center w-full h-32 border-2 border-dashed border-slate-300 rounded-xl cursor-pointer bg-slate-50 hover:bg-emerald-50 hover:border-emerald-400 transition-all group">
class="flex flex-col items-center justify-center w-full h-32 border-2 border-dashed border-slate-300 dark:border-slate-700 rounded-xl cursor-pointer bg-slate-50 hover:bg-emerald-50 dark:hover:bg-emerald-900/20 hover:border-emerald-400 transition-all group">
<div class="flex flex-col items-center justify-center pt-5 pb-6">
<span class="text-3xl mb-2 group-hover:scale-110 transition-transform">📄</span>
<p class="text-sm text-slate-600 font-medium">Click to upload FASTA</p>
Expand All @@ -125,7 +125,7 @@ <h2 class="text-lg font-extrabold flex items-center text-slate-900">
class="text-[10px] font-extrabold text-slate-500 uppercase tracking-widest flex items-center">
Sequence Input Area
<span id="inputTypeBadge"
class="ml-2 px-1.5 py-0.5 rounded bg-slate-200 text-slate-600 hidden text-[9px]">DNA</span>
class="ml-2 px-1.5 py-0.5 rounded bg-slate-200 dark:bg-slate-700 text-slate-600 hidden text-[9px]">DNA</span>
</p>
<div class="flex space-x-2">
<span id="inputLenBadge"
Expand Down Expand Up @@ -167,7 +167,7 @@ <h2 class="text-lg font-extrabold flex items-center text-slate-900">
</div>

<button id="clearBtn"
class="w-full py-2.5 px-4 bg-slate-100 hover:bg-slate-200 text-slate-700 font-semibold rounded-xl transition-all flex items-center justify-center space-x-2">
class="w-full py-2.5 px-4 bg-slate-100 hover:bg-slate-200 dark:bg-slate-800 dark:hover:bg-slate-700 text-slate-700 dark:text-slate-200 font-semibold rounded-xl transition-all flex items-center justify-center space-x-2">
<span>🗑️</span>
<span>Clear Input</span>
</button>
Expand Down Expand Up @@ -466,7 +466,7 @@ <h2 class="text-lg font-extrabold mb-6 flex items-center text-slate-900">
<label
class="flex items-center space-x-3 p-4 bg-slate-50 rounded-xl border border-slate-100 cursor-pointer hover:bg-slate-100 transition-colors">
<input type="checkbox" id="useTemplate"
class="w-5 h-5 text-emerald-600 rounded-md border-slate-300 focus:ring-emerald-500 transition-all">
class="w-5 h-5 text-emerald-600 rounded-md border-slate-300 dark:border-slate-600 focus:ring-emerald-500 transition-all">
<div>
<span class="flex items-center text-sm font-bold text-slate-800">
Standard Expression
Expand Down Expand Up @@ -747,7 +747,7 @@ <h3 class="text-lg font-semibold mb-3">Custom Restriction Sites</h3>
<span>Download GenBank</span>
</button>
<button id="copyBtn"
class="w-full py-3 px-4 bg-slate-100 hover:bg-slate-200 text-slate-700 font-bold rounded-xl flex items-center justify-center space-x-2 transition-all active:scale-95">
class="w-full py-3 px-4 bg-slate-100 hover:bg-slate-200 dark:bg-slate-800 dark:hover:bg-slate-700 text-slate-700 dark:text-slate-200 font-bold rounded-xl flex items-center justify-center space-x-2 transition-all active:scale-95">
<span>📋</span>
<span>Copy to Clipboard</span>
</button>
Expand All @@ -766,8 +766,8 @@ <h3 class="text-lg font-semibold mb-3">Custom Restriction Sites</h3>
<div class="mt-6 p-4 rounded-2xl border border-amber-200 bg-amber-50/60 dark:bg-amber-900/20 dark:border-amber-800/50">
<p class="text-[10px] font-extrabold text-amber-700 dark:text-amber-300 uppercase tracking-widest">Reviewer Disposition</p>
<div class="grid grid-cols-1 sm:grid-cols-[1fr_1fr] gap-2 mt-3">
<select id="reviewerDisposition" class="rounded-lg border border-amber-200 px-2 py-2 text-xs"><option value="">Record separately…</option><option value="accept">Accept</option><option value="accept_with_exception">Accept with exception</option><option value="return_for_redesign">Return for redesign</option><option value="reject">Reject</option></select>
<input id="reviewerReason" class="rounded-lg border border-amber-200 px-2 py-2 text-xs" placeholder="Reason (required for accepting FAIL)">
<select id="reviewerDisposition" class="rounded-lg border border-amber-200 dark:border-amber-800/50 bg-white dark:bg-slate-800 text-slate-700 dark:text-slate-200 px-2 py-2 text-xs"><option value="">Record separately…</option><option value="accept">Accept</option><option value="accept_with_exception">Accept with exception</option><option value="return_for_redesign">Return for redesign</option><option value="reject">Reject</option></select>
<input id="reviewerReason" class="rounded-lg border border-amber-200 dark:border-amber-800/50 bg-white dark:bg-slate-800 text-slate-700 dark:text-slate-200 placeholder-slate-400 dark:placeholder-slate-500 px-2 py-2 text-xs" placeholder="Reason (required for accepting FAIL)">
</div>
<button id="saveReviewerDisposition" class="mt-2 w-full rounded-lg bg-amber-600 text-white py-2 text-xs font-bold">Save reviewer disposition</button>
<p id="reviewerDispositionStatus" class="text-xs text-amber-800 dark:text-amber-200 mt-2"></p>
Expand Down Expand Up @@ -1490,7 +1490,7 @@ <h2 id="linkoutConsentTitle" class="text-lg font-bold">Leaving FactorForge</h2>
<div
class="flex items-center justify-center space-x-4 mb-4 grayscale opacity-40 hover:grayscale-0 hover:opacity-100 transition-all">
<span class="text-xs font-bold text-slate-400">FactorForge — Open Source</span>
<span class="w-1.5 h-1.5 bg-slate-300 rounded-full"></span>
<span class="w-1.5 h-1.5 bg-slate-300 dark:bg-slate-600 rounded-full"></span>
<span class="text-xs font-bold text-slate-400">AGPL-3.0 License</span>
</div>
<p class="text-xs text-slate-400 font-medium">© 2026 Eijex. Licensed under the GNU AGPL v3.0.</p>
Expand Down