Skip to content

chore: add weight info to estimation struct #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2024
Merged

chore: add weight info to estimation struct #30

merged 3 commits into from
May 15, 2024

Conversation

Rqnsom
Copy link
Member

@Rqnsom Rqnsom commented May 14, 2024 •
edited
Loading

This is a follow-up change according to the change in the pallet.
Now along with the gas_used info we also get total weight cost.

The new output:

Gas estimation:
             used gas: 53
             total extrinsic weight cost with the above gas:
                Weight { ref_time: 7160480763, proof_size: 242323 }
             vm_status_code: EXECUTED

Also in this PR:

Rqnsom added 2 commits May 14, 2024 13:33
@Rqnsom
chore: remove obsolete gas-to-weight rpc
5ba7a75
@Rqnsom
chore: add weight info to estimation struct
dda3133 
This is a follow-up change according to the change in the pallet.
Now along with the `gas_used` info we also get total weight cost.
@Rqnsom Rqnsom added the chore Small improvement label May 14, 2024
@Rqnsom Rqnsom self-assigned this May 14, 2024
neutrinoks
neutrinoks reviewed May 14, 2024
View reviewed changes
neutrinoks
neutrinoks previously approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@neutrinoks neutrinoks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One single comment, your choice about this input 😊

@Rqnsom Rqnsom force-pushed the chore/rpc-updates branch from 814ba60 to c11c442 Compare May 14, 2024 15:02
@Rqnsom Rqnsom force-pushed the chore/rpc-updates branch from c11c442 to dd4388e Compare May 14, 2024 15:11
@Rqnsom Rqnsom merged commit c8f42e9 into main May 15, 2024
1 check passed
@Rqnsom Rqnsom deleted the chore/rpc-updates branch May 15, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neutrinoks neutrinoks neutrinoks approved these changes

Assignees

@Rqnsom Rqnsom

Labels
chore Small improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rqnsom @neutrinoks