AMQP connection recovery creates extra connection/channel. #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z-sztrom
reviewed
Jul 13, 2023
| @Override | ||
| public void shutdownCompleted(ShutdownSignalException cause) { | ||
| log.debug("Connection Shutdown completed " + cause); | ||
| try { |
There was a problem hiding this comment.
I think the section is useless. The connection is always closed at that point of time...
There was a problem hiding this comment.
I have tested by removing this piece of code than I'm seeing more connections..,
There was a problem hiding this comment.
Hmm, very interesting... In that case we should change throwable to IOException or AlreadyClosedException or something what is thrown. Next, e.printStackTrace() should be removed---in fact we don't need any code there. Instead add a comment explainig why we have this try/catch block and that should not be removed.
z-sztrom
reviewed
Jul 13, 2023
publish-common/src/main/java/com/ericsson/eiffel/remrem/publish/helper/RabbitMqProperties.java
Outdated
Show resolved
Hide resolved
z-sztrom
reviewed
Jul 13, 2023
publish-common/src/main/java/com/ericsson/eiffel/remrem/publish/helper/RabbitMqProperties.java
Show resolved
Hide resolved
z-sztrom
reviewed
Jul 13, 2023
publish-common/src/main/java/com/ericsson/eiffel/remrem/publish/helper/RabbitMqProperties.java
Outdated
Show resolved
Hide resolved
z-sztrom
approved these changes
Jul 25, 2023
z-sztrom
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Description of the Change
Made the necessary changes to resolve extra AMQP connection issue.
Alternate Designs
Benefits
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Vishnu Alapati vishnu.alapati@tcs.com