Skip to content

Conversation

@z-sztrom
Copy link
Contributor

@z-sztrom z-sztrom commented Jun 23, 2023

Applicable Issues

Fixes #267
Fixes #268

Description of the Change

Non-existing link removed from documentation

Alternate Designs

Benefits

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Roman Szturc roman.szturc.ext@ericsson.com

@z-sztrom z-sztrom self-assigned this Jun 23, 2023
@z-sztrom z-sztrom requested a review from magnusbaeck June 23, 2023 13:07
@z-sztrom z-sztrom added the documentation Improvements or additions to the documentation. label Jun 23, 2023
@z-sztrom
Copy link
Contributor Author

Added solution of issue #268 in commit 42ea451.

@z-sztrom z-sztrom changed the title Documentation contains broken link to old GitHub pages Documentation contains broken link and bogus example Jun 23, 2023
Copy link
Member

@magnusbaeck magnusbaeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

If you change the issue reference under "Applicable issues" to

Fixes #267
Fixes #268

the PR and the issues will be correctly linked and closed when the PR is merged.

@z-sztrom
Copy link
Contributor Author

Links to fixed issues added to this PR.

@z-sztrom z-sztrom merged commit 1ac5a9f into eiffel-community:master Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logging documentation contains bogus example Documentation contains broken link to old GitHub pages

2 participants