Fixing missing events issues #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantoshNC68
reviewed
Sep 30, 2021
src/main/java/com/ericsson/ei/controller/RuleTestControllerImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ericsson/ei/handlers/DownstreamIdRulesHandler.java
Outdated
Show resolved
Hide resolved
RajuBeemreddy1
suggested changes
Oct 7, 2021
src/main/java/com/ericsson/ei/handlers/UpStreamEventsHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ericsson/ei/handlers/UpStreamEventsHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ericsson/ei/handlers/UpStreamEventsHandler.java
Outdated
Show resolved
Hide resolved
| Object ruleJSONObject; | ||
|
|
||
| // condition to avoid un-necessary exception to print in the log | ||
| if(mergeRule.startsWith("{")) { |
| public String addMissingLevels(String originObject, String objectToMerge, String mergeRule, String mergePath) { | ||
|
|
||
|
|
||
| LOGGER.info("addMissingLevels for arguments: before parse\n" |
| * @throws JSONException | ||
| */ | ||
| private void prepareEventsForTestAggregation(JSONArray listEventsJson, String suffix) throws MongoDBConnectionException{ | ||
| private void prepareEventsForTestAggregation(JSONArray listEventsJson, String suffix) throws JSONException, Exception{ |
| LOGGER.debug("Event to prepare aggregated object :: {}", | ||
| listEventsJson.getJSONObject(i).toString()); | ||
| eventHandler.eventReceived(listEventsJson.getJSONObject(i).toString()); | ||
| eventHandler.eventReceived(listEventsJson.getJSONObject(i).toString(), false); |
Member
There was a problem hiding this comment.
do we have any tests for the re-delivered events when it is true?
| } | ||
| } | ||
| // be inserted to database | ||
| objectHandler.updateObject(mergedObject, rules, event, id); |
Member
There was a problem hiding this comment.
Why this statement moved out from finally block? Unlocking the documents is performed at exceptions?
RajuBeemreddy1
suggested changes
Oct 18, 2021
| } | ||
|
|
||
| // be inserted to database | ||
| objectHandler.updateObject(mergedObject, rules, event, id); |
Member
There was a problem hiding this comment.
This statement should be inside the finally block after if block(null check.)
| if(aggregatedObject == null) { | ||
| return null; | ||
| } | ||
| if(aggregatedObject == null) { |
Member
There was a problem hiding this comment.
Seems tab spaces added. please check in all the places.
added 13 commits
October 21, 2021 19:06
Fixing missing events issues
This reverts commit 2d3571f.
RajuBeemreddy1
approved these changes
Oct 22, 2021
SantoshNC68
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Fixing missing events issues when multiple events were getting lost due to lock on mongoDB.
Description of the Change
Fixing missing events issues when multiple events were getting lost due to lock on mongoDB.
Alternate Designs
Benefits
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Vishalkumar Panchal vr.panchal@tcs.com