Skip to content

Conversation

@Christoffer-Cortes
Copy link
Contributor

@Christoffer-Cortes Christoffer-Cortes commented Jun 11, 2020

Applicable Issues

Description of the Change

The suggestions we had written in the issues was to properly resolve the port and trim away any extra port suffix from the thread name.
However, in this PR I simply remove the port since I'm not sure why it's logged in the first place.

Alternate Designs

Benefits

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: @Christoffer-Cortes

@Christoffer-Cortes Christoffer-Cortes requested a review from a team June 11, 2020 12:47
Copy link
Member

@e-pettersson-ericsson e-pettersson-ericsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and efficient 😄 ! However, I guess the open issues refer to the latest version, so I guess the PR targeting master branch should close those issues, and not this?

@Christoffer-Cortes Christoffer-Cortes merged commit 01a661f into eiffel-community:2.0.0-maintenance Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants