Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-tests-needed to add contributors #785

Merged
merged 1 commit into from
Sep 18, 2024
Merged

no-tests-needed to add contributors #785

merged 1 commit into from
Sep 18, 2024

Conversation

LukeLalor
Copy link
Collaborator

No description provided.

@LukeLalor LukeLalor enabled auto-merge (squash) September 17, 2024 17:25
@LukeLalor LukeLalor linked an issue Sep 17, 2024 that may be closed by this pull request
[ problem ] Tests Fail when all-contributors bot makes a pr. #704
Closed
abhi-vachani
abhi-vachani reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@abhi-vachani abhi-vachani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for asking me to review this so I could get more familiar with the codebase -- is the point of these changes to allow public contributors to not have to pass the automatic tests in place when creating a pr?

@LukeLalor
Copy link
Collaborator Author

Thanks for asking me to review this so I could get more familiar with the codebase -- is the point of these changes to allow public contributors to not have to pass the automatic tests in place when creating a pr?

Thanks for asking me to review this so I could get more familiar with the codebase -- is the point of these changes to allow public contributors to not have to pass the automatic tests in place when creating a pr?

correct, it does not impact the test runs, so there is no point running the tests when those files change.

abhi-vachani
abhi-vachani approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@abhi-vachani abhi-vachani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, awesome thanks. I'll approve this bc it seems like a simple change, but just curious then what are the github actions checking for / doing?

@LukeLalor LukeLalor merged commit 8824609 into main Sep 18, 2024
15 checks passed
@LukeLalor LukeLalor deleted the ll/all_contributors branch September 18, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhi-vachani abhi-vachani abhi-vachani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ problem ] Tests Fail when all-contributors bot makes a pr.
2 participants
@LukeLalor @abhi-vachani