Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/84 fix enum generation #92

Merged
merged 4 commits into from
Sep 30, 2020
Merged

Feature/84 fix enum generation #92

merged 4 commits into from
Sep 30, 2020

Conversation

stefanspiska
Copy link
Contributor

@stefanspiska
Merge branch 'develop' into feature/84_fix_enum_generation
69ecd1d 
# Conflicts:
#	test-data/src/main/java/org/ehrbase/test_data/operationaltemplate/OperationalTemplateTestData.java
@stefanspiska
edit changelog
bfeb86a
@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1174 Code Smells

90.5% 90.5% Coverage
19.8% 19.8% Duplication

jakesmolka
jakesmolka approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@jakesmolka jakesmolka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested my issue's example again and this time the defining codes where working (i.e. had meaningful and correct values).
I didn't go through the code, since 203 changed files are too much too browse through.

ppazos
ppazos reviewed Sep 29, 2020
View reviewed changes
...nition/BewertungDesGesundheitsrisikosBewertungDesGesundheitsrisikosVorhandenseinDvcode_.java
@@ -6,7 +6,7 @@

@Entity
@OptionFor("DV_CODED_TEXT")
public class BewertungDesGesundheitsrisikosVorhandenseinDvcodedtextSpezifischerRisikofaktor implements BewertungDesGesundheitsrisikosVorhandenseinChoice {
public class BewertungDesGesundheitsrisikosBewertungDesGesundheitsrisikosVorhandenseinDvcode_ implements BewertungDesGesundheitsrisikosVorhandenseinChoice {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefanspiska is the underscore at the end correct? seen that in other class names above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that means that the name was shortened.

ppazos
ppazos approved these changes Sep 29, 2020
View reviewed changes
Copy link

@ppazos ppazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefanspiska this is working OK :shipit:

@stefanspiska stefanspiska merged commit d7651b4 into develop Sep 30, 2020
@stefanspiska stefanspiska deleted the feature/84_fix_enum_generation branch September 30, 2020 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakesmolka jakesmolka jakesmolka approved these changes

@ppazos ppazos ppazos approved these changes

Assignees

@ppazos ppazos

@jakesmolka jakesmolka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enum not generated because name collision (?)
3 participants
@stefanspiska @ppazos @jakesmolka