Skip to content

Conversation

stefangr
Copy link
Contributor

@stefangr stefangr commented Mar 4, 2025

This issue resolves an issue when you use the EmailValidator for multiple email addresses without creating a new instance for every email address (Similar to issue 150).

Without this fix the added test will output

1) Egulias\EmailValidator\Tests\EmailValidator\EmailParserTest::testMultipleEmailAddresses Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'another-local-part'
+'some-random-but-large-domain-part.example.comanother-local-part'

Without this fix the added test will output

1) Egulias\EmailValidator\Tests\EmailValidator\EmailParserTest::testMultipleEmailAddresses
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'another-local-part'
+'some-random-but-large-domain-part.example.comanother-local-part'
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 51534601 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5153460) Report Missing Report Missing Report Missing
Head commit (5777388) 715 656 91.75%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#409) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@egulias
Copy link
Owner

egulias commented Mar 6, 2025

Thanks for the PR @stefangr !

@egulias egulias merged commit d42c873 into egulias:4.x Mar 6, 2025
7 checks passed
@stefangr stefangr deleted the cleanup-lexer-for-local-part branch March 7, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants