Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nightly] Small fixes #624

Merged
merged 2 commits into from
Jun 13, 2024
Merged

[Nightly] Small fixes #624

merged 2 commits into from
Jun 13, 2024

Conversation

ajpal
Copy link
Collaborator

@ajpal ajpal commented Jun 12, 2024

  1. Fix expand/collapse for llvm IR
  2. link to bril (on github) for each benchmark

@@ -121,42 +121,37 @@ function ConvertJsonToTable(
var value = parsedJson[i][headers[j]];
var isUrl = urlRegExp.test(value) || javascriptRegExp.test(value);

if (isUrl)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want this handling for urls (we do it ourselves in index.js)

Copy link
Member

@chandrakananandi chandrakananandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much!!

@ajpal ajpal requested a review from oflatt June 12, 2024 04:34
Copy link
Member

@oflatt oflatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@ajpal ajpal merged commit cf0807b into main Jun 13, 2024
4 checks passed
@ajpal ajpal deleted the ajpal-nightly branch June 13, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants