Fix errors for manuscript #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```r #> Warning: Unquoting language objects with `!!!` is deprecated as of rlang 0.4.0. Please #> use `!!` instead. #> #> # Bad: dplyr::select(data, !!!enquo(x)) #> #> # Good: dplyr::select(data, !!enquo(x)) # Unquote single quosure #> dplyr::select(data, !!!enquos(x)) # Splice list of quosures ```
build!: do not `generate_exclusion_subsets()` for `yi` pipeline - no effect. docs!: added explanation in vignette
…tlier_subsets()` for Zr pipeline build!: update corresponding argument supply to `filter_vars` - by wrapping in `rlang:exprs()` instead of `list()` for Zr and yi - explicitly supply `outcome_variable` and `outcome_SE` args for Zr
- Added conditional behaviour for when character vector supplied - feat!: added arg checks #116 and cli output for when this condition is triggered --- But wasn't failing for `yi` because `yi` received `rlang::expressions()` while `Zr` call used single length character variable for `outcome_variable` and `outcome_SE`
… `outcome_variable` - separated column creation to occur under three conditions: NULL outcome_variable supplied, character string supplied, and expression argument supplied - separated subset creation to occur separately on results of conditional evaluation
--- failed to be triggered as result needed to evaluate to TRUE for required expression to evaluate
--- Whenever mapped functions were called inside `ifelse()` statements in mutate calls without grouping, the same dataset (i.e. the first value) of the list-column was getting passed over and over again. I think that's because `ifelse()` isn't vectorised... switched to rowwise approach described at <https://cran.r-project.org/web/packages/dplyr/vignettes/rowwise.html> to avoid this problem, but also to explicitly enforce rowwise functionality without having to explicitly group to permit generalisability #97
--- forgot to add `c()` around character strings for cli message
data subset columns now NOT explicitly named, only model outputs from `meta_analyse_datasets()` and `prepare_response_variables()` --- fixes for #130 broke `make_viz()`
was originally only included to generate hard-coded columns, now no longer needed with #121 / #130 updates, and was never planned: <https://egouldo.github.io/ManyAnalysts/#out-of-sample-predictions-y_i-2>
`broom::tidy()` doesn't have method for `lmerMod` class
egouldo
added
documentation
manuscript
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dplyrfilter_varsforyipipeline output build!: do notgenerate_exclusion_subsets()foryipipeline - no effect. docs!: added explanation in vignettedevtools::document()generate_outlier_subsets()for Zr pipelinemeta_analyse_datasets()failing forManyEcoEvo_resultsgenerate_outlier_subsets()failing when char vec supplied foroutcome_variablefit_uni_mixed_effects()Bug fixes for Manuscript submission #130rowwise()execution inmeta_analyse_datasets()fit_uni_mixed_effects()Bug fixes for Manuscript submission #130ungroup()results ofrowwise()Bug fixes for Manuscript submission #130make_viz()yiresults Bug fixes for Manuscript submission #130broom.mixed::tidy()Bug fixes for Manuscript submission #130devtools::document()tar_make()renv::snapshot()