Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check random effects structure in deviation on peer-ratings models #153

Open
egouldo opened this issue Sep 14, 2024 · 1 comment
Open

Check random effects structure in deviation on peer-ratings models #153

egouldo opened this issue Sep 14, 2024 · 1 comment
Assignees
Labels
bug an unexpected problem or unintended behavior

Comments

@egouldo
Copy link
Owner

egouldo commented Sep 14, 2024

See: egouldo/ManyAnalysts#80 (comment)

After re-running the systematic checks on the updated pipeline, the following holds:

  1. continuous ratings, $Z_r$: Reviewer ID as random effect
  2. categorical ratings, $Z_r$: effect ID / study ID as random effect
  3. continuous ratings, $y_i$: Reviewer ID is the only random effect generating converging, singular models
  4. categorical ratings, $y_i$: effect ID / study ID is the random effect that generates the most number of converging, non-singular models across all out-of-sample estimates for both datasets.

I note that the current version of the functions does not match these results:

PublishableAsIs +
(1 | ReviewerId)

RateAnalysis +
(1 | study_id) # NOTE: ReviewerId removed due to singularity

@egouldo egouldo added the bug an unexpected problem or unintended behavior label Sep 14, 2024
@egouldo egouldo added this to the Respond Reviewer Comments milestone Sep 14, 2024
@egouldo egouldo self-assigned this Sep 14, 2024
egouldo added a commit that referenced this issue Sep 14, 2024
  - and add details explaining model structure and required data structure in roxygen documentation #102
  - don't pointblank check for box_cox column, let user's value be checked #116
  - update data checks to match required model structure #116
@egouldo
Copy link
Owner Author

egouldo commented Sep 14, 2024

Local .Rprofile detected at /Users/elliotgould/Documents/GitHub/ManyEcoEvo/.Rprofile

library(tidyverse)
library(insight)
#> Warning: package 'insight' was built under R version 4.4.1
library(targets)

tar_read(ManyEcoEvo_viz) %>%
  filter(str_detect(model_name, "box_cox"), !str_detect(model_name, "no_int")) %>%
  filter(if_all(ends_with("_subset"), ~ .x == "All"), exclusion_set == "complete") %>%
  ungroup() %>%
  select(-ends_with("set"), dataset, starts_with("model_")) %>%
  unite(model_name, dataset, model_name, remove = F, sep = "-") %>%
  rowwise() %>%
  mutate(mod_call = list(insight::get_call(model))) %>%
  pull(mod_call, model_name)
#> Registered S3 method overwritten by 'parsnip':
#>   method          from 
#>   print.nullmodel vegan
#> Registered S3 method overwritten by 'lava':
#>   method         from    
#>   print.estimate EnvStats
#> $`blue tit-box_cox_rating_cont`
#> lme4::lmer(formula = box_cox_abs_deviation_score_estimate ~ RateAnalysis + 
#>     (1 | ReviewerId), data = data_tbl)
#> 
#> $`blue tit-box_cox_rating_cat`
#> lme4::lmer(formula = box_cox_abs_deviation_score_estimate ~ PublishableAsIs + 
#>     (1 | study_id), data = data_tbl)
#> 
#> $`eucalyptus-box_cox_rating_cont`
#> lme4::lmer(formula = box_cox_abs_deviation_score_estimate ~ RateAnalysis + 
#>     (1 | ReviewerId), data = data_tbl)
#> 
#> $`eucalyptus-box_cox_rating_cat`
#> lme4::lmer(formula = box_cox_abs_deviation_score_estimate ~ PublishableAsIs + 
#>     (1 | study_id), data = data_tbl)

Created on 2024-09-14 with reprex v2.1.0

egouldo added a commit that referenced this issue Sep 14, 2024
egouldo added a commit that referenced this issue Sep 16, 2024
and delete selection of column starting with "box_cox" since user supplies outcome variable name now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant