Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't subset rm outliers on partial exclusion-set, subset on complete #136

Closed
egouldo opened this issue Sep 1, 2024 · 1 comment · Fixed by #138
Closed

don't subset rm outliers on partial exclusion-set, subset on complete #136

egouldo opened this issue Sep 1, 2024 · 1 comment · Fixed by #138
Assignees
Labels
bug an unexpected problem or unintended behavior

Comments

@egouldo
Copy link
Owner

egouldo commented Sep 1, 2024

Targets pipeline creates data subsets with outliers removed on partial exclusion set, but we want it on complete.

library(ManyEcoEvo)
#> Loading required package: rmarkdown
#> Loading required package: bookdown
#> Registered S3 method overwritten by 'parsnip':
#>   method          from 
#>   print.nullmodel vegan
#> Registered S3 method overwritten by 'lava':
#>   method         from    
#>   print.estimate EnvStats
ManyEcoEvo_viz %>% dplyr::distinct(exclusion_set)
#> # A tibble: 3 × 1
#>   exclusion_set      
#>   <chr>              
#> 1 complete           
#> 2 partial            
#> 3 partial-rm_outliers

Created on 2024-09-01 with reprex v2.1.0

@egouldo egouldo added the bug an unexpected problem or unintended behavior label Sep 1, 2024
@egouldo egouldo added this to the Respond Reviewer Comments milestone Sep 1, 2024
@egouldo egouldo self-assigned this Sep 1, 2024
egouldo added a commit that referenced this issue Sep 1, 2024
@egouldo
Copy link
Owner Author

egouldo commented Sep 1, 2024

Looks like 0e4ac8c did the trick

Local .Rprofile detected at /Users/elliotgould/Documents/GitHub/ManyEcoEvo/.Rprofile

targets::tar_read(ManyEcoEvo_viz) |> dplyr::distinct(exclusion_set)
#> Registered S3 method overwritten by 'parsnip':
#>   method          from 
#>   print.nullmodel vegan
#> Registered S3 method overwritten by 'lava':
#>   method         from    
#>   print.estimate EnvStats
#> # A tibble: 3 × 1
#>   exclusion_set       
#>   <chr>               
#> 1 complete            
#> 2 partial             
#> 3 complete-rm_outliers

Created on 2024-09-01 with reprex v2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant