StrictHash #236
Merged
StrictHash #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If there are any issues - please tell me, I will be glad to fix/adjust them! |
| @@ -393,6 +393,25 @@ def validate_hash(hash) | |||
| end | |||
| end | |||
|
|
|||
| # Use this to specify the Hash characteristics with strict check of keys' | |||
There was a problem hiding this comment.
Could you elaborate on "strict check of keys' presence"? It would be nice to say "the contracts fails if there are any extra keys that don't have contracts on them".
|
@cbrwizard this looks awesome! Thank you for adding documentation and tests. I left two small comments for you, it is good to merge after those are fixed. |
|
@egonSchiele thanks, here is an update! |
Adds a StrictHash builtin contract, which checks that the argument is a hash, and every key passed is present in the given contract. egonSchiele#235
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a StrictHash builtin contract, which checks that the argument is
a hash, and every key passed is present in the given contract.
#235