-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RangeOf[...] implemented #171
Conversation
E.g. RangeOf[Nat] or RangeOf[String] or ... Includes tests but not TUTORIAL.md as that is under potential change from pull request egonSchiele#170.
Can you use && instead of and? I don't see a reason to not add this to tutorial in this PR. Otherwise looks good.
|
* Changed 'and' to '&&' * Added RangeOf to TUTORIAL.md
Both done in commit baed1fd. |
Hmm... I tested on one machine and had no problem. (I forget the ruby version of that machine and can't access it right now.) But now on another machine I've got errors. Another commit needed. As a matter of interest, one of these is bad code: 3.is_a? Integer and 6 > 3
3.is_a? Integer && 6 > 3 |
&& instead of 'and' means parentheses are required for is_a?
Yeah, that is why |
Rubocop reports some issues on travis, can you fix them ? |
Done using local rubocop. |
E.g. RangeOf[Nat] or RangeOf[String] or ...
Includes tests but not TUTORIAL.md as that is under potential change
from pull request #170.
[Feature request #169]