Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeOf[...] implemented #171

Merged
merged 5 commits into from
Jul 4, 2015
Merged

Conversation

gsinclair
Copy link
Contributor

E.g. RangeOf[Nat] or RangeOf[String] or ...

Includes tests but not TUTORIAL.md as that is under potential change
from pull request #170.

[Feature request #169]

E.g. RangeOf[Nat] or RangeOf[String] or ...

Includes tests but not TUTORIAL.md as that is under potential change
from pull request egonSchiele#170.
@gsinclair gsinclair mentioned this pull request Jul 3, 2015
@alex-fedorov
Copy link
Collaborator

Can you use && instead of and?

I don't see a reason to not add this to tutorial in this PR.

Otherwise looks good.
On Jul 3, 2015 7:24 AM, "Gavin Sinclair" notifications@github.com wrote:

E.g. RangeOf[Nat] or RangeOf[String] or ...

Includes tests but not TUTORIAL.md as that is under potential change
from pull request #170

#170.

You can view, comment on, or merge this pull request online at:

#171
Commit Summary

  • RangeOf[...] implemented

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#171.

* Changed 'and' to '&&'
* Added RangeOf to TUTORIAL.md
@gsinclair
Copy link
Contributor Author

Both done in commit baed1fd.

@gsinclair
Copy link
Contributor Author

Hmm... I tested on one machine and had no problem. (I forget the ruby version of that machine and can't access it right now.) But now on another machine I've got errors. Another commit needed.

As a matter of interest, one of these is bad code:

3.is_a? Integer and 6 > 3
3.is_a? Integer && 6 > 3

&& instead of 'and' means parentheses are required for is_a?
@waterlink
Copy link
Collaborator

Yeah, that is why && is preferred in ruby community: and has unexpected operator priority.

@waterlink
Copy link
Collaborator

Rubocop reports some issues on travis, can you fix them ?

@gsinclair
Copy link
Contributor Author

Done using local rubocop.

egonSchiele added a commit that referenced this pull request Jul 4, 2015
@egonSchiele egonSchiele merged commit 1016bd9 into egonSchiele:master Jul 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants