Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix maybe proc #142

Merged
merged 1 commit into from
Apr 29, 2015
Merged

Fix maybe proc #142

merged 1 commit into from
Apr 29, 2015

Conversation

sfcgeorge
Copy link
Contributor

Fixes #139

@sfcgeorge
Copy link
Contributor Author

Before we weren't checking for Maybe[Proc] in the has_proc_contract test. Simple fix, though the code is a bit edge-casey. I can't think of a better way without completely rewriting the arg parsing code again.

@waterlink
Copy link
Collaborator

looks good enough to me

egonSchiele added a commit that referenced this pull request Apr 29, 2015
@egonSchiele
Merge pull request #142 from sfcgeorge/maybe_proc
cf1e9e0 
Fix maybe proc
@egonSchiele egonSchiele merged commit cf1e9e0 into egonSchiele:master Apr 29, 2015
@egonSchiele
Copy link
Owner

Yay, thank you! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combining Args and Optional Proc fails
3 participants
@sfcgeorge @waterlink @egonSchiele