-
-
Notifications
You must be signed in to change notification settings - Fork 256
Conversation
In which case the |
Yeah! If not this PR will do nothing |
so why do we need this PR? |
As issue #237 When webpack config is return a multi configs |
@qqcome110 Ah I see |
Hmm,
So why do you return an array of webpack configs in |
When you run |
they actually should have consistent behavior IMO. |
You mean that they are all return 1st one compiler? |
I don't get it, why do you return multi webpack config and only use the first one. |
I get your mean, If return multi webpack config can weigh whether to support multiple servers |
IMO the main problem of this issue would be: currently Poi could not support multi compiler. And the PR just solve this problem, but we need to confirm:
And since webpack-dev-server has already support a multiple compiler config (see the comment here which points out that this PR has solved the problems), IMO we should create multiple webpack-dev-server instances but I haven't got time to verify this theory. cc @qqcome110 |
Any ideas about this PR? @egoist |
08bf8c2
to
ff70c50
Compare
5c96c31
to
a5603cb
Compare
dbf9be6
to
cc6a243
Compare
e527c57
to
1a30e03
Compare
Support multi-compiler from issue #237
When the
poi dev
command encounters multiple compilers, there are two solutionsIf there are more than one compiler, this PR will take the 1st one as the processing object
If there are more than one compiler, this PR will terminate and prompt the error message to the user
Now this PR apply Solution A
I don't know how to deal with the more appropriate, please give a feedback