Fix gotkick(): unset chan.status CHAN_ACTIVE #1842
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: https://github.com/michaelortmann/
Patch by: https://github.com/michaelortmann/
Fixes: Found by analyzing #1723, not sure if it fixes the original bug, but this PR fixes a bug anyway
One-line summary:
Fix gotkick(): unset chan.status CHAN_ACTIVE
Additional description (if needed):
check_lonely_channel()could try to cycle the channel on join, even tho the bot should remember it is not on that channel anymoretcl_channel_modify()could try to sendPARTon chan setting change to+inactive, even tho the bot should remember it is not on that channel anymoreThis PR also fixes the delay (til next full minute) between changing chan setting -inactive and actually (re)joining the chan
Test cases demonstrating functionality (if applicable):
Load the following tcl script:
Then let the bot join a channel
And then kick the bot from that channel
At last
Before:
After: