Skip to content

Fix format truncation #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaelortmann wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix format truncation #1779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dcc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,14 +603,14 @@ struct dcc_table DCC_FORK_BOT = {
*/
static int dcc_bot_check_digest(int idx, char *remote_digest)
{
char digest_string[33]; /* 32 for digest in hex + null */
char digest_string[35]; /* 32 for digest in hex + null, but also used for (1) */
unsigned char digest[16];
int i, ret;
char *password = get_bot_pass(dcc[idx].user);

if (!password)
return 1;
snprintf(digest_string, 33, "<%lx%lx@", (long) getpid(),
snprintf(digest_string, sizeof digest_string, "<%lx%lx@", (long) getpid(), /* (1) */
(unsigned long) dcc[idx].timeval);
#if (OPENSSL_VERSION_NUMBER >= 0x10100000L) && defined(HAVE_EVP_MD5)
EVP_MD_CTX *mdctx = EVP_MD_CTX_new();
Expand Down
Loading